-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added char lists syntax highlighting #544
Conversation
I think this is a good idea. The only thing I'm not sure of here is whether or not this will affect indent rules which ignore special characters (e.g. vim-elixir/autoload/elixir/indent.vim Line 148 in c3cb96e
|
I'm sorry, I'm not sure what is the rule we are talking about here, but I tried to type these snippets in my vim: defmodule Hi do
| defmodule Hi do
def hello do
"Hello"
| defmodule Hi do
def hello do
"Hello"
end
| The One maybe questionable decision is using Line 233 in a7cf8c9
Line 238 in a7cf8c9
If we change it to |
I pushed up a fix for the indent code I think we should link |
I think it is a very good ideia. I agree that linking them to The bug fix is also great 👏 |
I believe that strings and charlists deserve different highlighting group, since those are very different data types.
Even if it is defaulted to regular vim string, it would make a little easier for us to customize our own colors.
The motivation behind this is that I ran into a bug when I was pattern matching the wrong value because I didn't notice I wrote single quoted "strings" instead of double quoted strings by mistake, and different colors for them would have saved me some minutes and a couple of head scratches.
I made this change today and I'm not sure they are 100% safe and did not break anything. I do not excel in those syntax groups of vim, but it seems to be working.
Comments and changes to my piece of code are more than welcome, and if this change is not what we want/need, then we can close this pull request.
Thanks for reading and providing us with this good content! (:
fixes #545