Syntax: Add private declarations #471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The formatting necessitated some significant whitespace changes. I’d recommend taking a look with whitespace changes hidden. |
|
This looks good to me. I'd like to pull it and just verify on my local tonight |
Why --- I want to be able to differentiate between public and private declarations How --- * Add **elixirPrivateFunctionDeclaration** group * Add **elixirPrivateRecordDeclaration** group * Add **elixirPrivateMacroDeclaration** group * Link **elixirPrivateFunctionDeclaration** to **elixirFunctionDeclaration** to preserve behavior * Link **elixirPrivateRecordDeclaration** to **elixirRecordDeclaration** to preserve behavior * Link **elixirPrivateMacroDeclaration** to **elixirMacroDeclaration** to preserve behavior * Add **elixirPrivateFunctionDeclaration**, **elixirPrivateRecordDeclaration**, and **elixirPrivateMacroDeclaration** to **elixirDeclaration** cluster
bryanenders
force-pushed
the
syntax/private-declarations
branch
from
3437204 to
f6585e5
Compare
|
@jbodah How’d it work out? |
|
I haven't been able to test it yet - ran into some issues with the test suite due to a previous merge; I should be able to run these this afternoon I did find one issue with the previous PR: #477 |
|
This seems good to me 👍 |
kelvinst
pushed a commit
to kelvinst/vim-elixir
that referenced
this pull request
Aug 21, 2019
Why --- I want to be able to differentiate between public and private declarations How --- * Add **elixirPrivateFunctionDeclaration** group * Add **elixirPrivateRecordDeclaration** group * Add **elixirPrivateMacroDeclaration** group * Link **elixirPrivateFunctionDeclaration** to **elixirFunctionDeclaration** to preserve behavior * Link **elixirPrivateRecordDeclaration** to **elixirRecordDeclaration** to preserve behavior * Link **elixirPrivateMacroDeclaration** to **elixirMacroDeclaration** to preserve behavior * Add **elixirPrivateFunctionDeclaration**, **elixirPrivateRecordDeclaration**, and **elixirPrivateMacroDeclaration** to **elixirDeclaration** cluster
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
I want to be able to differentiate between public and private declarations
How