Fix syntax highlighting with "~S" sigil#457
Merged
jbodah merged 1 commit intoelixir-editors:masterfrom Dec 12, 2018
feliperenan:fix-sigils-syntax
Merged
Fix syntax highlighting with "~S" sigil#457jbodah merged 1 commit intoelixir-editors:masterfrom feliperenan:fix-sigils-syntax
jbodah merged 1 commit intoelixir-editors:masterfrom
feliperenan:fix-sigils-syntax
Conversation
Collaborator
|
Thanks, looks great! Would you mind adding a test for this? Here's an example: https://github.com/elixir-editors/vim-elixir/blob/master/spec/syntax/doc_spec.rb#L27-L36 I'll run those prior on my machine and merge if it all looks good |
Contributor
Author
|
@jbodah Tests added. I'm not sure if they are covering the scenarios correctly though, could you please take a look? |
Collaborator
|
Looks good - thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #438
Just changed to use the same pattern used in
elixirStringvim-elixir/syntax/elixir.vim
Line 77 in 34873ee
Before
After