Basic matching for function definitions #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the matching for functions and for macros so that the function name/macro name is highlighted correctly. Also updated the snippets for both functions and macros so that they create function names by default. Without providing a name it highlights the `do` as the function name which looks odd.
keathley
force-pushed
the
match-function-definitions
branch
from
59e3e2f to
9cae73d
Compare
keathley
added a commit
that referenced
this pull request
Feb 8, 2016
Basic matching for function definitions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Highlight function declarations properly. Later we can use this initial pattern to match arguments to functions as well.
Currently this only matchesThe match works for both function and macro definitions.defanddefp. It would also make sense to matchdefmacroanddefmacrop.As part of this change I've also updated the function and macro snippets to add a default name. Without this the match registers the
doas the definition which can look odd. Adding an default name conveniently solves this issue while also being more explicit.