Skip to content

Do not shutdown on binding error #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 30, 2015
Merged

Conversation

fishcakez
Copy link
Member

This is a bug fix for tag v0.10.0. The bug is fixed on master by coincidence. Could we have a branch for v0.10 so we can backport fixes without introducing prepare/execute into v0.10.*? This PR is not mergable.

This bug was reported in #129 but was hidden by an issue with Ecto (see elixir-ecto/ecto#1161).

@fishcakez
Copy link
Member Author

Ah, 6210d10 fixes the issue so not by coincidence. I am unsure we need a v0.10 branch then but we should cherry pick the test in this branch.

I am unsure if we need to tag a patch release. I just would have preferred not to tag a release with prepare/execute because the API changes slightly in #128. I am happy with whatever @ericmj would like to do though.

@ericmj
Copy link
Member

ericmj commented Dec 28, 2015

If it's already fixed I don't see the need for a new release that just adds a test? If v0.11 takes time and other fixes are needed for v0.10 we can cherry-pick this. Sounds good?

@fishcakez
Copy link
Member Author

Yeah sounds good. I am unsure how frequent a binding error is. https://gitub.com/ericmj/postgrex/commit/6210d103da812e2478785859ea241ed07faa1bec can be applied to v0.10.0 so anyone facing this issue can use that in the meantime. I have rebased on master so we can merge the test.

fishcakez added a commit that referenced this pull request Dec 30, 2015
@fishcakez fishcakez merged commit 35c6065 into elixir-ecto:master Dec 30, 2015
@fishcakez fishcakez deleted the bind_error branch April 24, 2017 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants