Add {:nilify, columns} to on_delete reference option.
#474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
February 4, 2023 22:28
greg-rychlewski
changed the title
{:nilify, column_list} to on_delete reference option.{:nilify, columns} to on_delete reference option.
v0idpwn
approved these changes
Feb 5, 2023
josevalim
approved these changes
Feb 5, 2023
Sounds good to support it. At the same time nobody asked for it, so we are probably fine. :) Especially as nilifying likely covers the exact same cases. |
v0idpwn
approved these changes
Feb 5, 2023
Sorry I should have put it in description, this person here asked for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Postgres 15 allows the user to specify which columns should be set to null if the referenced record is deleted.
A side note: I noticed that one of the common on delete options from postgres/mysql is not present:
ON DELETE SET DEFAULT. I was wondering if this was on purpose or I can submit a PR to add it? I wasn't sure if it was left out on purpose to avoid having to do the same thing for associations.