Skip to content

Colorize stacktrace and use : before printing line number #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josevalim merged 1 commit into from
May 1, 2022
Merged

Colorize stacktrace and use : before printing line number #396

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion integration_test/sql/logging.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ defmodule Ecto.Integration.LoggingTest do

defp stacktrace_entry(line) do
"↳ anonymous fn/0 in Ecto.Integration.LoggingTest.\"test logs includes stacktraces\"/1, " <>
"at: integration_test/sql/logging.exs##{line - 3}"
"at: integration_test/sql/logging.exs:#{line - 3}"
end

test "when some measurements are nil" do
Expand Down
3 changes: 2 additions & 1 deletion lib/ecto/adapters/sql.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1178,6 +1178,7 @@ defmodule Ecto.Adapters.SQL do
with [_ | _] <- stacktrace,
{module, function, arity, info} <- last_non_ecto(Enum.reverse(stacktrace), repo, nil) do
[
IO.ANSI.light_black(),
?\n,
"↳ ",
Exception.format_mfa(module, function, arity),
Expand All @@ -1189,7 +1190,7 @@ defmodule Ecto.Adapters.SQL do
end

defp log_stacktrace_info([file: file, line: line] ++ _) do
[", at: ", file, ?#, Integer.to_string(line)]
[", at: ", file, ?:, Integer.to_string(line)]
end

defp log_stacktrace_info(_) do
Expand Down