Conversation
d0b9a86 to
31b5d17
Compare
efc065c to
0ed4cad
Compare
Schultzer
left a comment
There was a problem hiding this comment.
Thank you! This looks good to me, I’m currently on vacation and away from my computer.
I’m not sure why the action did not run for your PR.
yea. I believe it's the default behavior of not running CI for forked branch. We need to specify trigger it in pull_request in .github/workflow/ci.yml (I did run the test locally and it passed) |
The conformance tests broke https://github.com/elixir-dbvisor/sql/actions/runs/15372760900/job/43254022513 If you’re up for it, please push a PR which adds the changes to our actions and fixes the parser for the conformance tests. You can generate conformance test: Keep in mind that it requires you to clone elliotchance/sqltest |
Sure. I will try to fix it next week |
closes #14