Closed
Conversation
romlogic
reviewed
Dec 7, 2018
| import javax.annotation.Nullable; | ||
|
|
||
| /** | ||
| * Client for reading from and writing to existing Bigtable tables. |
There was a problem hiding this comment.
Line 44. Client for reading from, and writing to the existing Bigtable tables.
| return readRowsCallable().first().futureCall(query); | ||
| } | ||
|
|
||
| /** |
There was a problem hiding this comment.
I know , you did not touch the below line, but above , in line 243, you have said, "Convenience method for synchronously reading a single row." Therefore, to make it similar, just rephrase the below to add "ly":
Convenience method for synchronously streaming the results of a {@link Query}.
Other Notes, I'd prefer complete sentences, but all across, it is not. So, it is your call. Only this edit is a must. Others are your call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.