Check gensim version and set size parameter name respectively #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@eliorc I would also suggest setting the specific version of your dependency in your setup.py file. This would prevent such bugs in the future. WDYT? |
Owner
I'd rather not at the moment, there aren't many contributors to this lib, so I basically maintain it alone. I wouldn't have the availability to make sure the packages are updated, so I rather let them auto update so users of this package will enjoy the latest of the dependencies. This way, when something breaks I can see because of good people like yourself and fix it |
Owner
|
Solves #59 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #60. The change also fulfill your wishes in this comment #59 (comment)