Add Support for custom attributes #180
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
IDP like OKTA, Azure support custom attributes along with scim attributes. Today Resource type validations will drop all non-scim compliant attributes during validation
Solution
Adding a flag to allow non-SCIM compliant attributes, updating the validation logic to include these attributes
Support for custom attributes:
resource_type.go: AddedAllowNonScimKeysflag toResourceTypeto allow non-SCIM compliant attributes. Updated thevalidatemethod to include these attributes in the resource type. [1] [2]Testing enhancements:
handlers_test.go: Added theAllowNonScimKeysflag to thenewTestServerfunction and created a new testTestServerResourceHandlerWithCustomAttributesto verify the handling of custom attributes. [1] [2]utils_test.go: Added a helper functionassertEqualMapsto compare maps in tests.