Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python 3 upgrade #17

Closed
wants to merge 8 commits into from
Closed

python 3 upgrade #17

wants to merge 8 commits into from

Conversation

lsh-0
Copy link
Contributor

@lsh-0 lsh-0 commented Jan 13, 2020

  • switches loris back to official repository
  • rebuilds virtualenv using python3

rebuilds virtualenv using python3
@lsh-0
Copy link
Contributor Author

lsh-0 commented Jan 13, 2020

I think there is a race condition somewhere. I'm getting this sporadically:

----------
          ID: loris-setup
    Function: cmd.run
        Name: venv/bin/python setup.py install

      Result: False
     Comment: Command "venv/bin/python setup.py install
              " run
     Started: 06:33:38.989060
    Duration: 216.71 ms
     Changes:   
              ----------
              pid:
                  12299
              retcode:
                  1
              stderr:
                  Traceback (most recent call last):
                    File "setup.py", line 244, in <module>
                      install_requires=install_requires,
                    File "/opt/loris/venv/lib/python3.6/site-packages/setuptools/__init__.py", line 145, in setup
                      return distutils.core.setup(**attrs)
                    File "/usr/lib/python3.6/distutils/core.py", line 148, in setup
                      dist.run_commands()
                    File "/usr/lib/python3.6/distutils/dist.py", line 955, in run_commands
                      self.run_command(cmd)
                    File "/usr/lib/python3.6/distutils/dist.py", line 974, in run_command
                      cmd_obj.run()
                    File "setup.py", line 103, in run
                      self.__make_directories()
                    File "setup.py", line 146, in __make_directories
                      self.__init_dir(d)
                    File "setup.py", line 164, in __init_dir
                      stdout.write('Set permissions for %s to 0755\n' % (d,))
                  ValueError: underlying buffer has been detached
              stdout:
                  running install

@lsh-0
Copy link
Contributor Author

lsh-0 commented Jan 14, 2020

ValueError: underlying buffer has been detached

I have no idea. Maybe I will just stick it in a container. Trying one last thing to see if I can replicate these problems locally

@lsh-0
Copy link
Contributor Author

lsh-0 commented Jan 14, 2020

@lsh-0
Copy link
Contributor Author

lsh-0 commented Jan 14, 2020

I still can't figure it out. It has something to do with the /var/log/loris directory - changing the mode on that in setup.py breaks sys.stdout.write, detaching the buffer and then BOOM - fucked.

It shouldn't be trying to create directories and chmod them anyway. I know it's a large project, but geez.

@lsh-0
Copy link
Contributor Author

lsh-0 commented Jan 16, 2020

containerisation efforts happening here: #18

@lsh-0 lsh-0 mentioned this pull request Jan 16, 2020
8 tasks
@lsh-0
Copy link
Contributor Author

lsh-0 commented Jan 20, 2020

urgh - wrong ticket

@lsh-0 lsh-0 closed this Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant