Skip to content

Conversation

@sgammon
Copy link
Member

@sgammon sgammon commented Nov 2, 2025

Ready for review Powered by Pull Request Badge

Summary

Fixes several build-time issues w.r.t. macOS x86-64 support.

@sgammon sgammon added this to the Release R18: Beta milestone Nov 2, 2025
@sgammon sgammon self-assigned this Nov 2, 2025
@sgammon sgammon added the bug Something isn't working label Nov 2, 2025
@sgammon sgammon added this to Elide Nov 2, 2025
@sgammon sgammon added P0 platform:macos Issues relating to macOS arch:amd64 Issues relating to amd64/x64/x86_64 labels Nov 2, 2025
@sgammon sgammon changed the title fix(local-ai): llama cpp crate on macos x86-64 fix: macos x86-64 releases Nov 2, 2025
@sgammon sgammon linked an issue Nov 2, 2025 that may be closed by this pull request
@sgammon sgammon moved this to In Progress in Elide Nov 2, 2025
@codecov
Copy link

codecov bot commented Nov 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 40.23%. Comparing base (e88fb61) to head (ccdcede).
⚠️ Report is 25 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1723      +/-   ##
==========================================
+ Coverage   40.00%   40.23%   +0.23%     
==========================================
  Files         888      888              
  Lines       37072    37088      +16     
  Branches     5685     5684       -1     
==========================================
+ Hits        14829    14921      +92     
+ Misses      20305    20229      -76     
  Partials     1938     1938              
Flag Coverage Δ
jvm 40.23% <ø> (+0.23%) ⬆️
lib 40.23% <ø> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 11 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7aa2162...ccdcede. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sgammon sgammon force-pushed the fix/macos-x86 branch 3 times, most recently from e0d297a to a4f9efa Compare November 5, 2025 03:57
Signed-off-by: Sam Gammon <sam@elide.dev>
Signed-off-by: Sam Gammon <sam@elide.dev>
Signed-off-by: Sam Gammon <sam@elide.dev>
Signed-off-by: Sam Gammon <sam@elide.dev>
Signed-off-by: Sam Gammon <sam@elide.dev>
Signed-off-by: Sam Gammon <sam@elide.dev>
Signed-off-by: Sam Gammon <sam@elide.dev>
Signed-off-by: Sam Gammon <sam@elide.dev>
Signed-off-by: Sam Gammon <sam@elide.dev>
Signed-off-by: Sam Gammon <sam@elide.ventures>
Signed-off-by: Sam Gammon <sam@elide.ventures>
Signed-off-by: Sam Gammon <sam@elide.ventures>
Signed-off-by: Sam Gammon <sam@elide.ventures>
Signed-off-by: Sam Gammon <sam@elide.ventures>
Signed-off-by: Sam Gammon <sam@elide.ventures>
Signed-off-by: Sam Gammon <sam@elide.ventures>
Signed-off-by: Sam Gammon <sam@elide.ventures>
Signed-off-by: Sam Gammon <sam@elide.ventures>
Signed-off-by: Sam Gammon <sam@elide.ventures>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arch:amd64 Issues relating to amd64/x64/x86_64 bug Something isn't working P0 platform:macos Issues relating to macOS

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

Restore support for macOS x86-64

2 participants