[FIRRTL] Update parser for OMDeleted targets.

All targets require the colon after the target kind, even OMDeleted.
elhewaty · Mar 15, 2024 · f1d478b · f1d478b
1 parent c848464
commit f1d478b
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/lib/Dialect/FIRRTL/Transforms/ResolvePaths.cpp b/lib/Dialect/FIRRTL/Transforms/ResolvePaths.cpp
@@ -107,7 +107,7 @@ struct PathResolver {
     // OMDeleted nodes do not have a target, so it is impossible to resolve
     // them to a real path.  We create a special constant for these path
     // values.
-    if (target.consume_front("OMDeleted")) {
+    if (target.consume_front("OMDeleted:")) {
       if (!target.empty())
         return emitError(loc, "OMDeleted references can not have targets");
       // Deleted targets are turned into OMReference targets with a dangling

diff --git a/test/Dialect/FIRRTL/resolve-paths-errors.mlir b/test/Dialect/FIRRTL/resolve-paths-errors.mlir
@@ -12,7 +12,7 @@ firrtl.module @BadTargetKind() {
 firrtl.circuit "BadPathString" {
 firrtl.module @BadPathString() {
     // expected-error @below {{OMDeleted references can not have targets}}
-    %0 = firrtl.unresolved_path "OMDeleted:"
+    %0 = firrtl.unresolved_path "OMDeleted:~Foo|Bar>baz"
 }
 }
 

diff --git a/test/Dialect/FIRRTL/resolve-paths.mlir b/test/Dialect/FIRRTL/resolve-paths.mlir
@@ -4,7 +4,7 @@
 firrtl.circuit "Deleted" {
 firrtl.module @Deleted() {
     // CHECK: %0 = firrtl.path reference distinct[0]<>
-    %0 = firrtl.unresolved_path "OMDeleted"
+    %0 = firrtl.unresolved_path "OMDeleted:"
 }
 }
 
@@ -15,7 +15,7 @@ firrtl.circuit "Deleted" {
 firrtl.module @Deleted(out %path : !firrtl.path) {
     // CHECK: %0 = firrtl.path reference distinct[0]<>
     // CHECK: propassign %path, %0 : !firrtl.path
-    %0 = firrtl.unresolved_path "OMDeleted"
+    %0 = firrtl.unresolved_path "OMDeleted:"
     firrtl.propassign %path, %0 : !firrtl.path
 }
 }