[LLHD] Verify empty processes (llvm#6801)

elhewaty · Mar 8, 2024 · a4a1eb6 · a4a1eb6
1 parent 95a2f94
commit a4a1eb6
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/include/circt/Dialect/LLHD/IR/StructureOps.td b/include/circt/Dialect/LLHD/IR/StructureOps.td
@@ -125,7 +125,7 @@ def LLHD_ProcOp : LLHD_Op<"proc", [
     OptionalAttr<DictArrayAttr>:$arg_attrs,
     OptionalAttr<DictArrayAttr>:$res_attrs
   );
-  let regions = (region AnyRegion: $body);
+  let regions = (region MinSizedRegion<1>: $body);
 
   let extraClassDeclaration = [{
     /// Verify the type attribute of this function. Returns failure and emits

diff --git a/test/Dialect/LLHD/IR/inst-errors.mlir b/test/Dialect/LLHD/IR/inst-errors.mlir
@@ -62,3 +62,13 @@ llhd.entity @moduleTypeMismatch() -> (%arg0: !llhd.sig<i3>) {
   // expected-error @+1 {{output type mismatch}}
   llhd.inst "inst" @module() -> (%arg0) : () -> !llhd.sig<i3>
 }
+
+// -----
+
+// expected-error @below {{region #0 ('body') failed to verify constraint: region with at least 1 blocks}}
+llhd.proc @empty() -> () {}
+
+// -----
+
+// expected-error @below {{empty block: expect at least a terminator}}
+llhd.proc @empty(%a: !llhd.sig<i1>) -> () {}