refactor(audio-player): cache audioRef.current to avoid repeated access to the 'current' property #54
+12
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
In the current implementation of
useAnimationFrame, we have repeated access to theaudioRef.currentto update the states.In the new changes, I cached the reference in a variable ( const ) and reuse it without duplication. In addition to that, I used the guard clause pattern to check the
audioreference.Why
Additional
We can also use object destructuring to extract the properties from
audioto avoid ( but also check before set ) redundancy. Let me know if you prefer this pattern to follow up with a commit.