Skip to content

fix: avoid blocking AsyncConversation startup - #818

Merged
PaulAsjes merged 1 commit into
elevenlabs:mainfrom
ogarciarevett:fix/async-signed-url
Jul 23, 2026
Merged

fix: avoid blocking AsyncConversation startup#818
PaulAsjes merged 1 commit into
elevenlabs:mainfrom
ogarciarevett:fix/async-signed-url

Conversation

@ogarciarevett

Copy link
Copy Markdown
Contributor

Summary

AsyncConversation.start_session() currently performs the authenticated signed-URL request synchronously on the event-loop thread. Run that existing synchronous helper in the loop executor so authenticated startup does not pause unrelated async work.

Closes #811.

Tests

  • Added a regression test that verifies signed-URL resolution runs outside the event-loop thread.
  • python -m pytest tests/test_async_convai.py -q on Python 3.8.20 — 10 passed
  • python tests/verify_types.py — 1,570 type files passed
  • mypy . — 2,246 source files passed
  • ruff check tests/test_async_convai.py

@PaulAsjes PaulAsjes left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AsyncConversation and async client

2 participants