Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New functions for unsupported endpoints + some modifications #41

Merged
merged 9 commits into from
Jun 4, 2023

Conversation

theAbdoSabbagh
Copy link
Contributor

This PR brings support to multiple endpoints that I noticed were not supported in this wrapper:

  1. /v1/voices/settings/default
  2. /v1/voices/{voice_id}/settings
  3. /v1/voices/{voice_id}/settings/edit
  4. /v1/voices/{voice_id}
  5. /v1/voices/{voice_id}/edit
  6. /v1/history/{history_item_id}
  7. /v1/user/subscription

I've also modified the following:

  1. Subscription class: Added new properties.
  2. User class: the from_api function was not working so I fixed it.

@flavioschneider
Copy link
Collaborator

Thanks for the PR! I added some comments for things I'd do differently

@theAbdoSabbagh
Copy link
Contributor Author

Thanks for the PR! I added some comments for things I'd do differently

You're welcome! Also, I can't see any comment. Have you submitted the review?

elevenlabs/api/user.py Outdated Show resolved Hide resolved
elevenlabs/api/user.py Outdated Show resolved Hide resolved
elevenlabs/api/voice.py Outdated Show resolved Hide resolved
elevenlabs/api/voice.py Outdated Show resolved Hide resolved
elevenlabs/api/voice.py Outdated Show resolved Hide resolved
elevenlabs/simple.py Outdated Show resolved Hide resolved
elevenlabs/api/voice.py Outdated Show resolved Hide resolved
elevenlabs/api/user.py Show resolved Hide resolved
elevenlabs/api/history.py Show resolved Hide resolved
elevenlabs/api/voice.py Outdated Show resolved Hide resolved
@theAbdoSabbagh
Copy link
Contributor Author

I just pushed 3 commits that do as you've requested :)

@theAbdoSabbagh
Copy link
Contributor Author

Also may I ask why you use dict() instead of {}?

@flavioschneider
Copy link
Collaborator

Thanks! I like dict() more because the keys are not written as strings

Copy link
Collaborator

@flavioschneider flavioschneider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few more comments

elevenlabs/api/voice.py Outdated Show resolved Hide resolved
elevenlabs/api/voice.py Outdated Show resolved Hide resolved
@theAbdoSabbagh
Copy link
Contributor Author

Done!

@flavioschneider flavioschneider merged commit bfae742 into elevenlabs:main Jun 4, 2023
@flavioschneider
Copy link
Collaborator

Perfect, thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants