Skip to content
This repository was archived by the owner on Mar 28, 2024. It is now read-only.

Allow optional time limit for chill mode #104

Merged
merged 9 commits into from
Oct 26, 2021

Conversation

mtrunt
Copy link
Contributor

@mtrunt mtrunt commented Oct 17, 2021

Description

Allow users so modify the time limit on the chill modes, from 10 seconds to 3 minutes.

For these changes the possibility of passing keyed options to the commands was added.
e.g. to start the game you would type !tfchill time 30 for a game with a 30 second time limit for each question.

closes #40

Type of change

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)

Copy link
Owner

@elenirotsides elenirotsides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR @mtrunt ! I've made some comments and suggestions, please see below. Awesome job!

@mtrunt mtrunt requested a review from elenirotsides October 25, 2021 04:32
@mtrunt
Copy link
Contributor Author

mtrunt commented Oct 25, 2021

@elenirotsides I submitted the changes. One of the main things is the change on validateCommands return value. Instead of true for failure I changed it to false since it makes more sense IMO and the truthy value is the validated arguments now.

Let me know if you have any questions🙂

@elenirotsides
Copy link
Owner

Instead of true for failure I changed it to false since it makes more sense IMO and the truthy value is the validated arguments now.

I totally agree with you, thanks!

Copy link
Owner

@elenirotsides elenirotsides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for your contribution! The work you did here is fantastic! I'm just going to go ahead and commit the minor changes I've suggested below. Other than that, this is some really really good stuff here. Thanks again for the killer PR!

@elenirotsides elenirotsides merged commit 274e610 into elenirotsides:main Oct 26, 2021
@mtrunt
Copy link
Contributor Author

mtrunt commented Oct 26, 2021

Thanks! I like the work you have done with the bot so far 😀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow user to increase timer
2 participants