Skip to content

Conversation

@Nevoss
Copy link
Member

@Nevoss Nevoss commented Jun 23, 2025

✨ PR Description

Purpose: Removes the editor_v2:false experiment flag and standardizes environment variable case in GitHub Actions configuration files.

Main changes:

  • Removed editor_v2:false experiment flag from test-actions.yml workflow
  • Updated input variable casing to uppercase in all .env.example files
  • Added ENABLE-SVG-UPLOAD parameter to setup-elementor-env .env.example file

Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using. We'd love your feedback! 🚀

@Nevoss Nevoss requested a review from Copilot June 23, 2025 10:49
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request fixes issues with local run inputs by standardizing the input variable names in the environment example files.

  • Changed variable names in .env.example files to uppercase for consistency.
  • Updated input variable names in several GitHub Actions workflows to adhere to the INPUT_ format.

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

File Description
actions/trickle-down-changelog/.env.example Changed INPUT_token to INPUT_TOKEN for naming consistency.
actions/setup-wp-env/.env.example Updated multiple input names to uppercase; note naming inconsistency with dashes.
actions/setup-elementor-env/.env.example Updated input names to uppercase and added a new INPUT_ENABLE-SVG-UPLOAD variable (uses a dash).
actions/run-lighthouse-tests/.env.example Updated input names to uppercase; note naming inconsistency with dashes.
Comments suppressed due to low confidence (5)

actions/setup-wp-env/.env.example:20

  • [nitpick] Consider renaming the key to use underscores instead of dashes (e.g., INPUT_ACTIVE_THEME) to adhere consistently to the INPUT_ format.
INPUT_ACTIVE-THEME=hello-elementor

actions/setup-wp-env/.env.example:21

  • [nitpick] Consider renaming the key to use underscores instead of dashes (e.g., INPUT_SKIP_WP_ENV_INSTALL) for consistency with GitHub Actions input naming conventions.
INPUT_SKIP-WP-ENV-INSTALL=false

actions/setup-elementor-env/.env.example:10

  • [nitpick] Consider renaming the key to avoid dashes (e.g., INPUT_ENABLE_SVG_UPLOAD) to maintain consistency with the INPUT_ format.
INPUT_ENABLE-SVG-UPLOAD=false

actions/run-lighthouse-tests/.env.example:15

  • [nitpick] Consider renaming the key to use underscores (e.g., INPUT_NUMBER_OF_RUNS) to align with the INPUT_ naming convention.
INPUT_NUMBER-OF-RUNS=3

actions/run-lighthouse-tests/.env.example:16

  • [nitpick] Consider renaming the key to use underscores (e.g., INPUT_SKIP_LHCI_INSTALL) for consistency with the INPUT_ format.
INPUT_SKIP-LHCI-INSTALL="false"

gitstream-cm[bot]

This comment was marked as resolved.

gitstream-cm[bot]

This comment was marked as resolved.

gitstream-cm[bot]

This comment was marked as resolved.

@Nevoss Nevoss merged commit a937baf into elementor:main Jun 23, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants