Half of the Wingpanel overlaps application windows

[misaelgs]

What Happened?

From fresh installation any of the application windows draged to the top of the screen or when you are in maximized mode, half of the wingpanel overlaps it.

Steps to Reproduce

1. Fresh elementary OS 8 installation
2. Hardware Macbook Pro 13" mid 2014

Expected Behavior

Wingpanel should not overlap application windows, since part of the menu is cut.

OS Version

8.x (Circe)

Session Type

Classic Session (X11, This is the default)

Software Version

Latest release (I have run all updates)

Log Output

No response

Hardware Info

Macbook air 13" Mid 2014
Intel HD Graphics 5000 - Retina Display
2560 by 1600 pixels

[marmeladapk]

Also happens to me in wayland session. It seems to happen with 200% scaling.

[marmeladapk]

I also encountered the following scenario which I believe is related:

1. Launch wayland session with a single monitor with 200% scaling
2. Wingpanel has the correct spacing (which is not always the case)
3. Then connect a monitor with 100% scaling
4. Wingpanel on 100% monitor leaves blank space between maximized window and itself
   

[syneryder]

I'm encountering the same thing, using a Lenovo ThinkPad X1 Yoga 3rd Gen, connected to an external 24" Dell monitor set to HiDPI 2x scaling. Both my external Dell and internal Lenovo laptop screen have 2560x1440 resolution. Problem occurs for me both in Classic X11 and Secure Wayland.

I know elementary is understaffed, but this is one of the many usability issues preventing me from using 8.0. I keep having to revert back to 7.1 instead. Lots of the issues I'm encountering in 8.0 relate to incorrect HiDPI scaling, or not accounting for an external monitor set as the primary desktop and positioned to the left of the internal display. This all worked in 7.1. A lot of the attention to accessibility that 7.1 had (ie being able to scale up controls 2x to be readable, both on HiDPI displays and for aging eyes) has been lost in 8.0.

I post this with love, despite my criticism - I really want elementaryOS to succeed, it's still the distro I'd most like to use, if I was able to.

[lagoshny]

The bug appiers after this commit message

Now get_actual_height returns only as get_allocated_height() without get_scale_factor() and we have the bad panel heigh.

If try to change condition to

        if (!Services.DisplayConfig.is_logical_layout () || Gdk.Display.get_default () is Gdk.Wayland.Display) {
            return get_allocated_height () * get_scale_factor ();
        }

it is works as desired.

@leolost2605 can you review these chagnes again and fix it?

[danirabbit]

@lagoshny Could you make a pull request with your changes please? :)

[lagoshny]

@danirabbit Ok, did it #601