Use CSS for muted-blocking animation #138
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cassidyjames
reviewed
Mar 3, 2020
Comment on lines
+43
to
+49
| @keyframes volume-blocking { | ||
| 0% { -gtk-icon-transform: rotate(20deg); } | ||
| 25% { -gtk-icon-transform: rotate(-20deg); } | ||
| 50% { -gtk-icon-transform: rotate(10deg); } | ||
| 75% { -gtk-icon-transform: rotate(-10deg); } | ||
| 100% { -gtk-icon-transform: rotate(5deg); } | ||
| } |
Contributor
There was a problem hiding this comment.
I like it in general, but the rotation feels weird to me since that icon is not visually weighted in the center. What about a side-to-side wiggle?
Suggested change
| @keyframes volume-blocking { | |
| 0% { -gtk-icon-transform: rotate(20deg); } | |
| 25% { -gtk-icon-transform: rotate(-20deg); } | |
| 50% { -gtk-icon-transform: rotate(10deg); } | |
| 75% { -gtk-icon-transform: rotate(-10deg); } | |
| 100% { -gtk-icon-transform: rotate(5deg); } | |
| } | |
| @keyframes volume-blocking { | |
| 20% { -gtk-icon-transform: translateX(4px); } | |
| 40% { -gtk-icon-transform: translateX(-4px); } | |
| 60% { -gtk-icon-transform: translateX(2px); } | |
| 80% { -gtk-icon-transform: translateX(-2px); } | |
| 100% { -gtk-icon-transform: translateX(1px); } | |
| } |
Member
Author
|
This also has an issue with light wallpapers where the transition to change color is very long. So it seems like we need some kind of other approach for transitioning back |
Collaborator
|
@danrabbit I am converting this to draft as it blocked and there is no recent activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #137
Fixes #136
Instead of changing icon name, we transition color with CSS and add a little wiggle while we're at it
Since the current muted icon in the icon set is partial opacity, that is also preserved here. This will need to be changed in icons.
Made the transition a bit faster because: