Fix crash on captive portal Wi-Fi by ensuring NMConnection is fully initialized#354
Merged
stsdc merged 2 commits intoelementary:masterfrom Nov 23, 2025
Merged
Fix crash on captive portal Wi-Fi by ensuring NMConnection is fully initialized#354stsdc merged 2 commits intoelementary:masterfrom
stsdc merged 2 commits intoelementary:masterfrom
Conversation
Contributor
Author
|
NOTE: I tested this fix by creating a captive portal using my laptop's hotspot and nodogsplash , which I connected to with my PC. I never really saw a captive portal window, but it effectively did simulate the bug because it crashed my wingpanel everytime I would try to connect to it. |
stsdc
requested changes
Nov 22, 2025
stsdc
approved these changes
Nov 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #351
Crash happens because the indicator sometimes creates an NM.SimpleConnection without a NM.SettingConnection, which causes libnma’s NMA.WifiDialog to assert and abort wingpanel.
The fix was to ensure that every connection passed to NMA.WifiDialog has both NM.SettingConnection and NM.SettingWireless attached, and only uses the dialog for secured networks. For open networks, it skips the dialog and directly activates the connection.
The inspiration for this fix was me trying to match the behavior of the Network settings plug, because things work fine there.