Merged
Conversation
Set state based on rfkill device change Change to airplane mode less namespace Try all rather than any All hardware OR all software
danirabbit
force-pushed
the
danirabbit/airplanemode-rfkill
branch
from
a477f78 to
6f93af5
Compare
Member
We shouldn't disable Bluetooth, should we? I remember Android used to disable Bluetooth on airplane mode but they removed it because people use wireless headphones/other peripherals and people expect them to keep working even in airplane mode |
Member
Author
|
@lenemter okay yeah I can confirm on my iPhone as well that airplane mode only turns off cellular and wireless, it doesn't turn off bluetooth. Updated! |
leonardo-lemos
approved these changes
May 3, 2025
Collaborator
leonardo-lemos
left a comment
leonardo-lemos
left a comment
There was a problem hiding this comment.
Works as expected and code looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes Airplane Mode so that it uses RFKill to disable radios, not disable all networking. This means Airplane mode correctly disables wifi and cellular, but not wired networking
Partially fixes #45. The toggle is now correct but the indicator is not