Merged
Conversation
Remove extra whitespace
danirabbit
force-pushed
the
danirabbit/settings-toggle
branch
from
2a1e9c6 to
5bb4cff
Compare
leonardo-lemos
approved these changes
Apr 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Can be rebase merged
Creates a SettingsToggle widget like we did in Quick Settings. This should eventually be moved into Wingpanel, but kind of prototyping in indicators first to make sure it covers all the cases before proposing to the library. Couple things different here from the one in Quick Settings:
FlowBoxChild. We're using FlowBox now, but we might want to use GridView later or a box or something else. Just future proofing ourselvessetand noneconstruct. This is in case we want to create these widgets from a model like in GridView where we recycle widgets.action-nameinstead ofactive. Avoids some jank. This is the recommended way to handle ToggleButtons in GTK and it means we can set disabled states more cleanly etc