Skip to content

meson: Require gio-2.0 >= 2.74#331

Merged
danirabbit merged 1 commit intomasterfrom
ryonakano/require-gio-2.74
Apr 23, 2025
Merged

meson: Require gio-2.0 >= 2.74#331
danirabbit merged 1 commit intomasterfrom
ryonakano/require-gio-2.74

Conversation

@ryonakano
Copy link
Member

We now use GLib.ListStore.n_items since #326:

     private void check_vpn_availability () {
-        show_vpn (vpn_list.get_child_at_index (0) != null);
+        show_vpn (vpn_list.n_items > 0);
     }

This is available on gio-2.0 >= 2.74 as written in Valadoc, so make sure to require it. Also explicit that we require libnm-dev >= 1.24 in README


I noticed this because the daily recipe of wingpanel-indicator-network fails in Jammy:

https://code.launchpad.net/~elementary-os/+archive/ubuntu/daily/+build/30646060

../src/Widgets/VpnInterface.vala:57.19-57.34: error: `GLib.ListStore.n_items' is not available in gio-2.0 2.72.4. Use gio-2.0 >= 2.74
   57 |         show_vpn (vpn_list.n_items > 0);
      |                   ^~~~~~~~~~~~~~~~      
Compilation failed: 1 error(s), 0 warning(s)
ninja: build stopped: subcommand failed.

Our development target is now Noble, so I dropped Jammy from the above recipe.

@ryonakano ryonakano requested a review from a team April 23, 2025 13:40
@ryonakano
Copy link
Member Author

I also changed recipes for stable:

  • Renamed wingpanel-indicator-network-stable recipe which builds from the horus branch of this repository to wingpanel-indicator-network-horus
  • Drop Noble from the distribution series of wingpanel-indicator-network-horus
  • Created a new branch named noble from horus branch in this repository
  • Created a new recipe for Noble: wingpanel-indicator-network-noble which builds from the noble branch of this repository

Copy link
Collaborator

@leonardo-lemos leonardo-lemos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@danirabbit danirabbit merged commit e3b6f96 into master Apr 23, 2025
4 checks passed
@danirabbit danirabbit deleted the ryonakano/require-gio-2.74 branch April 23, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants