Skip to content

Add airplane mode switch to popover; add middle-click tooltip#235

Merged
danirabbit merged 6 commits intomasterfrom
add-airplane-mode-control
Nov 30, 2022
Merged

Add airplane mode switch to popover; add middle-click tooltip#235
danirabbit merged 6 commits intomasterfrom
add-airplane-mode-control

Conversation

@jeremypw
Copy link
Collaborator

@jeremypw jeremypw commented Oct 5, 2021

Fixes #6
Fixes #8

Needs input on:

  • position of airplane mode switch
  • whether the switch should be available in the greeter as well as in the session

@jeremypw
Copy link
Collaborator Author

jeremypw commented Oct 5, 2021

Tooltip
NetworkingMiddleClickTooltip

Popover
AirPlaneSwitchTop

@ryonakano
Copy link
Member

I'm not familiar with UX, but I feel like the airplain switch in the popover should be placed in the top of it; the number of wireless networks is mutable, so the position of switch also may differ every time users opens the popover.

Also, the actions triggered by middle-clicking in other indicators also have a switch for that action in the top of their popovers, so placing the switch there would be consistent.

@jeremypw
Copy link
Collaborator Author

@ryonakano Thanks for the review! I can easily put the switch right at the top of the popover instead of right at the bottom. Anywhere else is a little more complicated.

Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me! Nice job :)

@danirabbit danirabbit enabled auto-merge (squash) November 30, 2022 20:21
@danirabbit danirabbit merged commit 1c19314 into master Nov 30, 2022
@danirabbit danirabbit deleted the add-airplane-mode-control branch November 30, 2022 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add missing airplane mode switch to menu Set middle click action

3 participants