Add airplane mode switch to popover; add middle-click tooltip#235
Merged
danirabbit merged 6 commits intomasterfrom Nov 30, 2022
Merged
Add airplane mode switch to popover; add middle-click tooltip#235danirabbit merged 6 commits intomasterfrom
danirabbit merged 6 commits intomasterfrom
Conversation
Collaborator
Author
Member
|
I'm not familiar with UX, but I feel like the airplain switch in the popover should be placed in the top of it; the number of wireless networks is mutable, so the position of switch also may differ every time users opens the popover. Also, the actions triggered by middle-clicking in other indicators also have a switch for that action in the top of their popovers, so placing the switch there would be consistent. |
Collaborator
Author
|
@ryonakano Thanks for the review! I can easily put the switch right at the top of the popover instead of right at the bottom. Anywhere else is a little more complicated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Fixes #6
Fixes #8
Needs input on: