Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MainWindow: GTK4 prep #863

Merged
merged 5 commits into from
Feb 28, 2025
Merged

MainWindow: GTK4 prep #863

merged 5 commits into from
Feb 28, 2025

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented Feb 27, 2025

  • Bump license header
  • No more decoration_layout_set in GTK4
  • Explicit expands
  • Child property
  • More accurate cast, no more Gtk.Bin
  • ScrolledWindow doesn't take args in GTK4, so use vadjustment property
  • Minimize use of Gtk.Clipboard functions that are going away
  • Remove set_visual. This is I think really old stuff and it's not clear it even does anything for us in GTK3

@danirabbit danirabbit marked this pull request as ready for review February 27, 2025 00:44
@danirabbit danirabbit requested a review from a team February 27, 2025 00:44
Copy link
Collaborator

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and works as expected in Horus. There are problems with OS8 in a VM but I think this is appears to be associated with the automatic creation of new workspace on fullscreening. When that is turned off the problem goes away.

@jeremypw jeremypw merged commit 35691a5 into master Feb 28, 2025
4 checks passed
@jeremypw jeremypw deleted the danirabbit/mainwindow-gtk4prep branch February 28, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants