Port to Gtk4 #358
Port to Gtk4 #358
Conversation
| assert (source_rows[source] != null); | ||
| listbox.select_row (source_rows[source]); | ||
|
|
||
| } else if (last_selected_list == source.uid) { | ||
| assert (source_rows[source] != null); |
There was a problem hiding this comment.
was there a reason to add asserts here?
There was a problem hiding this comment.
I don't think there was, at least I don't remember it :)
There was a problem hiding this comment.
@lenemter afaict this is read to go maybe? I wasn't able to see which drag and drop issues you were referring to in your PR description. I just have one comment about some asserts that were added.
Would love if you wanted to walk through and double check everything here yourself just to be sure! But I'm going to mark this as ready for review :)
There was a problem hiding this comment.
There are some indentation issues in this file
|
We should update copyright year in the modified files |
|
@danirabbit I can't remember what 'Fix dnd when dragging into the task_list' referrers to, but 'Remove dnd to entries' is this bug: tasks-gt4-bug.mp4 |
|
Ah okay. I think I'm going to go ahead and merge even with that bug and then we can fix it in a follow up. I want to really rewrite task editing anyways |
Fixes #317
To do:
task_listtask_listFix a duplication of tasks when color of task list changes(Duplicated tasks in Scheduled view when changing color of the task list #359)