Skip to content

Conversation

@danirabbit
Copy link
Member

@danirabbit danirabbit commented May 6, 2025

Fixes #429

Rebase merge/review commits separately

  • Bind color scheme radios to color scheme gsetting with create_action
  • Bind dark schedule radios to dark schedule gsetting with create_action

Removes a bunch of complicated touching of accounts service and simplifies settings binding. When manually changing color scheme while schedule is enabled, schedule will be snoozed instead of changed to disabled. Settings Daemon now handles setting mutter settings, syncing accountsservice etc

@danirabbit danirabbit requested a review from a team May 6, 2025 20:01
@danirabbit danirabbit added this to OS 9 May 6, 2025
@danirabbit danirabbit moved this to Needs Review in OS 9 May 6, 2025
@danirabbit danirabbit mentioned this pull request May 13, 2025
1 task
@lenemter
Copy link
Member

We need to remove the old color scheme from accounts service then and update granite and elementary/greeter#786 to use it

@lenemter
Copy link
Member

Or we can remove this from granite entirely since granite already relies on portals

@danirabbit
Copy link
Member Author

@lenemter settings daemon already handles setting accountsservice when the key is changed, so I don't think there's any more changes needed here for that. It should still work the same

@lenemter
Copy link
Member

@danirabbit I found out about this too late lol. I've already proposed to remove color-scheme from accounts service

Copy link
Member

@lenemter lenemter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and works as expected

@danirabbit danirabbit merged commit b2cdc60 into main May 14, 2025
4 checks passed
@danirabbit danirabbit deleted the danirabbit/settings-color-scheme branch May 14, 2025 12:43
@github-project-automation github-project-automation bot moved this from Needs Review to Done in OS 9 May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Appearance schedule resets after switch to dark mode

2 participants