Merged
Conversation
lenemter
reviewed
Apr 5, 2023
Member
lenemter
left a comment
lenemter
left a comment
There was a problem hiding this comment.
Online account are deleted once logged out, right? So I think we shouldn't show them in guest sessions?
lenemter
reviewed
Apr 5, 2023
Member
Author
|
@lenemter Yeah I'm on the fence on that one. If you're logging in to the guest account to check your email I think maybe it still makes sense to point to where to set up online accounts? |
Member
|
@danirabbit Well, maybe. But IMO it's easier to use web browser than adding an online account if you're using guest session. Anyway, I don't confront your decision to show online accounts here. |
Member
Author
|
Yeah that's a good point. I'll remove it and we can always add it back in later if people make noise |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #204
Fixes elementary/triage#144