Skip to content

Update layout of UpdateView with links#116

Closed
zeebok wants to merge 9 commits intoelementary:masterfrom
zeebok:updateview-balance
Closed

Update layout of UpdateView with links#116
zeebok wants to merge 9 commits intoelementary:masterfrom
zeebok:updateview-balance

Conversation

@zeebok
Copy link
Contributor

@zeebok zeebok commented Nov 17, 2020

This addresses #106 and includes similar links as the welcome view.

@cassidyjames cassidyjames self-requested a review May 6, 2021 02:14
@jeremypw
Copy link
Collaborator

@zeebok There seems to have been a lot of changes to Onboarding since this was started - is it still needed? If so, it would be helpful to post "Before" and "After" screenshots.

@zeebok
Copy link
Contributor Author

zeebok commented Jul 29, 2021

@jeremypw Through all of the updates, the page that is affected hasn't changed so I think this PR is still relevant.
Before:
Screenshot from 2021-07-29 02-52-51
After:
Screenshot from 2021-07-29 02-52-41

@jeremypw
Copy link
Collaborator

jeremypw commented Jul 29, 2021

Hmm thats odd 🤔 After installing master from source and running gsettings reset io.elementary.onboarding viewed; io.elementary.onboarding I got a different view with more pages. The page shown below had similar text on one link was the same. However after rebooting and logging in again I do get the three page view so it seems I was getting confused between the post-install and the post-update views. Sorry for the confusion. Maybe the README.md needs to clarify this.

WelcomeToElementary

@zeebok
Copy link
Contributor Author

zeebok commented Aug 3, 2021

I do wonder if I should add the Community Support link to the What's New page as well. @cassidyjames what do you think?

@jeremypw jeremypw added the Needs Design Waiting for input from the UX team label Sep 7, 2021
@ahoneybun
Copy link

I feel like 3 items is pretty nice and even when it comes to sizing though if we need/want to add more 5 would be the next nice number.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Conflicts with master Needs Design Waiting for input from the UX team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants