Skip to content

CheckView: warn about daily builds #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danirabbit merged 3 commits into from
Nov 28, 2022
Merged

CheckView: warn about daily builds #668

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f35e226
CheckView: warn about daily builds
danirabbit Nov 28, 2022
8c12e06
Fix extra space
danirabbit Nov 28, 2022
3013116
Merge branch 'master' into checkview-prerelease
danirabbit Nov 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions src/Views/CheckView.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,12 @@ public class Installer.CheckView : AbstractInstallerView {
};
title_label.get_style_context ().add_class (Granite.STYLE_CLASS_H2_LABEL);

var beta_view = new CheckView (
_("Pre-Release Version"),
_("Only install on devices dedicated for development. <b>You will not be able to upgrade to a stable release</b>."),
"applications-development"
);

var space_view = new CheckView (
_("Not Enough Space"),
_("%s of storage or more is required to install %s.").printf (GLib.format_size (MINIMUM_SPACE), Utils.get_pretty_name ()),
Expand Down Expand Up @@ -99,6 +105,18 @@ public class Installer.CheckView : AbstractInstallerView {
minimum_specs = false;
}

var apt_sources = File.new_for_path ("/etc/apt/sources.list.d/elementary.list");
try {
var @is = apt_sources.read ();
var dis = new DataInputStream (@is);

if ("daily" in dis.read_line ()) {
message_box.add (beta_view);
}
} catch (Error e) {
critical ("Couldn't read apt sources: %s", e.message);
}

if (!enough_space) {
message_box.add (space_view);
ignore_button.sensitive = false;
Expand Down Expand Up @@ -218,6 +236,7 @@ public class Installer.CheckView : AbstractInstallerView {

var description_label = new Gtk.Label (description) {
max_width_chars = 1, // Make Gtk wrap, but not expand the window
use_markup = true,
wrap = true,
xalign = 0
};
Expand Down