Skip to content

Use settings-daemon background files #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lenemter wants to merge 3 commits into from
Closed

Use settings-daemon background files #671

lenemter wants to merge 3 commits into from

Conversation

@lenemter
Copy link
Member

@lenemter lenemter commented Jun 30, 2023

This was referenced Jun 30, 2023
Merged
Merged
@lenemter lenemter marked this pull request as draft July 3, 2023 06:42
@lenemter lenemter closed this Jul 3, 2023
@lenemter lenemter deleted the lenemter/use-settings-daemon-bg branch July 3, 2023 09:56
@lenemter lenemter restored the lenemter/use-settings-daemon-bg branch July 3, 2023 12:27
@lenemter lenemter reopened this Jul 3, 2023
@lenemter lenemter marked this pull request as ready for review July 3, 2023 12:27
@lenemter lenemter requested a review from a team July 3, 2023 12:27
@Marukesu
Copy link
Contributor

Marukesu commented Jul 3, 2023

So, there's a BackgroundFile property in the org.freedesktop.Accounts.User interface (i believe this is one of the ubuntu's patches, since i don't see it in the upstream XML), and in the org.freedesktop.DisplayManager.AccountsService one (this one is provided by LightDM i believe).

we should be using one of those instead of hardcoding a path.

@lenemter
Copy link
Member Author

lenemter commented Jul 3, 2023

@Marukesu I'll use org.freedesktop.DisplayManager.AccountsService because greeter already supports it, I just removed it here.

This requires some changes in elementary/settings-daemon#72 and this PR can be closed.

@lenemter lenemter closed this Jul 3, 2023
@danirabbit danirabbit deleted the lenemter/use-settings-daemon-bg branch July 3, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lenemter @Marukesu