Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Styles: support more PopoverMenu features #710

Merged
merged 8 commits into from
Mar 25, 2024
Merged

Styles: support more PopoverMenu features #710

merged 8 commits into from
Mar 25, 2024

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented Mar 22, 2024 •
edited
Loading

Support a bunch more PopoverMenu features

Todo:

  • Separator
  • disabled
  • mnemonics
  • Arrow
  • Kbd focus
  • check
  • radio

BEFORE

Screenshot from 2024-03-22 10 36 21

AFTER

Screenshot from 2024-03-22 10 34 19

@danirabbit danirabbit marked this pull request as draft March 23, 2024 18:58
@danirabbit danirabbit changed the base branch from main to danirabbit/demo-styles March 25, 2024 20:34
@danirabbit danirabbit marked this pull request as ready for review March 25, 2024 22:46
@danirabbit danirabbit merged commit c52d018 into danirabbit/demo-styles Mar 25, 2024
5 checks passed
@danirabbit danirabbit deleted the danirabbit/styles-modelmenu branch March 25, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@danirabbit