Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Placeholder: resize based on parent #678

Merged
merged 3 commits into from
Jan 22, 2024
Merged

Placeholder: resize based on parent #678

merged 3 commits into from
Jan 22, 2024

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented Jan 10, 2024 •
edited
Loading

Fixes #664

Screenshot from 2024-01-10 14 08 19

@danirabbit danirabbit requested a review from a team January 10, 2024 21:30
@danirabbit danirabbit mentioned this pull request Jan 10, 2024
Merged
jeremypw
jeremypw approved these changes Jan 22, 2024
View reviewed changes
Copy link
Collaborator

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nicely!

Not sure whether the entry should be active - or if so whether something should happen if you type in it, but that can be changed another PR if desired. This PR fulfils its aim.

@jeremypw jeremypw enabled auto-merge (squash) January 22, 2024 14:15
@jeremypw jeremypw merged commit 07e9f15 into main Jan 22, 2024
5 checks passed
@jeremypw jeremypw deleted the danirabbit/placeholder-parentsizing branch January 22, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremypw jeremypw jeremypw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Responsive placeholder
2 participants
@danirabbit @jeremypw