-
-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Settings Urls #649
Settings Urls #649
Conversation
Add string constants for URL links to settings pages from the Personal section. Add Settings URLs view to the Granite Demo app to showcase and test those links.
Hey thanks for starting in on this! I left a couple responses to the comments you left previously. Additionally I think we should probably keep this pretty tightly scoped to settings that we're sure are useful to developers so we don't end up with a bunch of extra un-useful constants to dig through. From the top of my head the things that seem useful are:
I'm not sure why, for example, an app other than Files would be linking to Housekeeping settings. |
I must admit I went into this one with a bit of a completionist mindset. 😅 But yeah, we can definitely start with a narrow set of links that seem more useful, and potentially add new ones down the line if there's interest. |
Ok, I checked the 3rd party apps in the AppCenter, and in addition to Nimbus requiring privacy, we have:
So yes, @lenemter, your pull request on keyboard settings is timed perfectly! I suggest adding |
Include just a selected set of deep Settings links and properly name-space them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job! Reasonable list, I think. Works as expected :)
Implements the Granite part of Settings Urls #190 issue from the docs repo.
Currently covers:
Links are showcased in a new demo app view as links: