Skip to content

Create a release action #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
danirabbit merged 6 commits into from
Jul 20, 2021
Merged

Create a release action #48

danirabbit merged 6 commits into from
Jul 20, 2021

Conversation

@danirabbit
Copy link
Member

@danirabbit danirabbit commented Jul 16, 2021 •
edited
Loading

No description provided.

@danirabbit
Copy link
Member Author

danirabbit commented Jul 16, 2021

@btkostner not exactly sure what I'm doing here. How can we make sure this goes to the stable release branch/channel/thing instead of "master" or "daily" or whatever in the appcenter flatpak repo?

@danirabbit danirabbit mentioned this pull request Jul 16, 2021
Merged
3 tasks
@btkostner
Copy link
Contributor

btkostner commented Jul 19, 2021

This should push to the 6.0 branch, that way people can target elementary 6.0 when building their applications. And then when we work on 7, it can go to 7.0 without breaking peoples apps.

btkostner
btkostner suggested changes Jul 19, 2021
View reviewed changes
@danirabbit danirabbit requested a review from btkostner July 19, 2021 17:18
@danirabbit danirabbit marked this pull request as ready for review July 19, 2021 17:18
@btkostner
Copy link
Contributor

btkostner commented Jul 20, 2021

@danrabbit @cassidyjames How are we going to version these moving forward. Gnome does 3.38, etc. But they also introduce breaking changes between them. If we are sticking to SemVer, there should only be breaking changes between 6 and 7, so doing io.elementary.Platform:6 would make sense and we just update that tag for every point release (6.1, 6.2, etc)

Otherwise, if we plan on having breaking changes between them, doing io.elementary.Platform:6.0 and io.elementary.Platform:6.1 is the way to go.

@danirabbit
Copy link
Member Author

danirabbit commented Jul 20, 2021

Yeah, I think semver is the way to go. So going with "6" as the branch makes sense to me

btkostner
btkostner approved these changes Jul 20, 2021
View reviewed changes
Copy link
Contributor

@btkostner btkostner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@btkostner
Copy link
Contributor

btkostner commented Jul 20, 2021

Fixes #5

@danirabbit danirabbit merged commit 89bdd3f into main Jul 20, 2021
@danirabbit danirabbit deleted the release-action branch July 20, 2021 00:32
@Marukesu Marukesu mentioned this pull request Jul 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@btkostner btkostner btkostner approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@danirabbit @btkostner