ChooseProjectButton: use a liststore to populate project list #1042
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremypw
approved these changes
May 20, 2021
jeremypw
pushed a commit
that referenced
this pull request
May 26, 2021
* Add ChooseProjectButton class * Add ChooseProjectButton to HeaderBar and react to add/remove project * ChooseProjectButton.vala: Update header * Fix lint * Use HeaderBar active project new-branch action * Use ChooseProjectButton active project for find-global action * Fix closing all except * FileView responsible for removing project from GitManager when closed * ChooseProjectButton: Expand horizontally, add top & bottom margins * ChooseProjectButton: Limit width to 24 chars * ChooseProjectButton: Set max chars and ellipsize * ChooseProjectButton: use max_content_height for scrolled (#1038) * ChooseProjectButton: bind ProjectEntry radio to active (#1040) * ChooseProjectButton: valign center (#1037) * ChooseProjectButton: subclass menubutton (#1039) * ChooseProjectButton.vala: Lose unused code get_radio_group () Co-authored-by: Daniel Foré <daniel@elementary.io> * Show project path in tooltip * Replace missing brace * ProjectEntry: Rename to ProjectRow * Remove duplicated code * Update src/Widgets/ChooseProjectButton.vala Co-authored-by: Daniel Foré <daniel@elementary.io> * Update src/Widgets/ChooseProjectButton.vala: Explict get/set Co-authored-by: Daniel Foré <daniel@elementary.io> * More concise names * Reduce scope if `img` * ChooseProjectButton: ellipsize long radio items * ChooseProjectButton: use a liststore to populate project list (#1042) * ChooseProjectButton: use a liststore to populate project list * scope down manager * smaller diff * remove unused method * Update src/Widgets/HeaderBar.vala: remove unused setter Co-authored-by: Daniel Foré <daniel@elementary.io> * GitManager: source of truth for active_project_path (#1044) * ChooseProjectButton: simplify ProjectRow click handling (#1041) * ChooseProjectButton: simplify ProjectRow click handling * actual fix * Allow non-git projects to fix global search (#1045) * Remove size group Co-authored-by: Jeremy Wootten <jeremy@elementaryos.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.