Patreon linked to GitHub doesn't count as sponsorship

[cyrneko]

What Happened?

I've pledged to Elementary over Patreon, making sure to link it with my GitHub account. Builds.elementary.io does not recognise this, even after @danirabbit manually added me to the whitelist.

Steps to Reproduce

1. Support via Patreon
2. Link GH and Patreon
3. Try logging in on builds.elementary.io

Expected Behavior

It should recognise that I am indeed sponsoring Elementary and allow me through.

OS Version

Other Linux

Software Version

Latest release (I have run all updates)

Log Output

Not Relevant

Hardware Info

Not Relevant

[danirabbit]

@lewisgoddard This should theoretically just work with Patreon right? Possibly closing #54? But it's weird that he still can't log in even after I added his username manually to the allow list. Any idea for debugging steps?

[cyrneko]

Because it is relevant:

At this point I have tried on a completely different device and fresh Firefox install

[darltrash]

any updates on this?

[lewisgoddard]

I have absolutely no idea for the allowlisting, that is a simple check in server/auth-callback.js, line 95.

Do we know anyone who is subscribed to the Patreon?

It might be something to do with the check that they are paying at least $1 a month.

I would like to know the output of this GitHub GraphQL query (they can be tested @ https://docs.github.com/en/graphql/overview/explorer)

{
  viewer {
    login
    organizations(last: 100) {
      nodes {
        login
      }
    }
    sponsorshipsAsSponsor(last: 100) {
      nodes {
        isActive
        paymentSource
        tier {
          monthlyPriceInCents
        }
        sponsorable {
          ... on User {
            login
          }
          ... on Organization {
            login
          }
        }
      }
    }
  }
}

[cyrneko]

okay so, small update on this after another attempt just now

Turns out, it seems the GitHub oAuth callback fails

In the network tab of the devtools, I can see it query https://builds.elementary.io/auth/callback?code=[REDACTED], which returns {"success":false} and a HTTP 200

which...yeah that doesn't seem right? builds.elementary.io is authorized according to GitHub's settings page on authorized oAuth apps 🤔

[cyrneko]

@lewisgoddard as per the GraphQL query you asked for, sorry for the terribly long delay, the notification must've gotten buried back then

{
  "data": {
    "viewer": {
      "login": "cyrneko",
      "organizations": {
        "nodes": []
      },
      "sponsorshipsAsSponsor": {
        "nodes": [
          {
            "isActive": true,
            "paymentSource": "PATREON",
            "tier": null,
            "sponsorable": {
              "login": "elementary"
            }
          }
        ]
      }
    }
  }
}

[RMcNeely]

I sponsor via Patreon and I am not seeing this data anywhere in the query at the link that Lewis provided.

Do you know if you have somehow linked Patreon to GitHub @cyrneko?

[cyrneko]

@RMcNeely yes I specifically connected a Patreon account to my GitHub one so that doing a Patreon sponsorship would count as a GitHub sponsorship, see my profile which is marked as sponsoring elementary

[RMcNeely]

hmm it must take some time to populate because I'm not seeing anything after linking my own Patreon account? 🤔

[cyrneko]

maybe! I linked it a long time ago, a bit before when I first made this issue