-
Notifications
You must be signed in to change notification settings - Fork 209
fix: apply toyaml filter to all secret-backed credential fields in profiles template #2124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+34
−25
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
ac63b89
refactor: replace opaque CI_PROFILES_YML secret with committed templa…
devin-ai-integration[bot] c2a16d4
fix: guard secret-dependent steps for docker targets (postgres, click…
devin-ai-integration[bot] cf1f222
refactor: replace shell-based profiles generation with Python CLI scr…
devin-ai-integration[bot] 451ebb3
refactor: use Jinja for-loop for elementary profile, remove legacy fa…
devin-ai-integration[bot] 01ddcd5
feat: use StrictUndefined when secrets are present to catch typos
devin-ai-integration[bot] b0cc1f4
fix: add isinstance(decoded, dict) validation for secrets JSON
devin-ai-integration[bot] a051188
fix: add auth_type:oauth for databricks, catch binascii.Error
devin-ai-integration[bot] a92a5b4
fix: revert docker/cloud split in elementary — run all targets under …
devin-ai-integration[bot] 22c5849
fix: add missing bigquery profile fields (location, priority)
devin-ai-integration[bot] ddf9761
Merge remote-tracking branch 'origin/master' into devin/ele-5262-1772…
devin-ai-integration[bot] 23f04ab
fix: apply toyaml filter to all secret-backed credential fields
devin-ai-integration[bot] 91f260c
fix: strip YAML document-end marker from toyaml filter for scalar values
devin-ai-integration[bot] 074cb29
fix: make toyaml filter type-aware — preserve int/bool, only quote am…
devin-ai-integration[bot] 49c6152
fix: toyaml filter — emit numeric strings as unquoted ints for port f…
devin-ai-integration[bot] 5f4f41e
fix: return empty string instead of empty dict for undefined values i…
devin-ai-integration[bot] 766a2c3
fix: add tests/profiles/** to workflow trigger paths
devin-ai-integration[bot] 25f34a0
refactor: simplify _yaml_inline function per review feedback
devin-ai-integration[bot] dc7625d
fix: broaden workflow trigger to tests/** to catch all test file changes
devin-ai-integration[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.