Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions elementary/cli/upgrade.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,16 @@
import click
from packaging import version

from elementary.config.config import Config
from elementary.utils import package


def recommend_version_upgrade():
config = Config()

if config.disable_elementary_version_check:
return

try:
latest_version = package.get_latest_package_version()
current_version = package.get_package_version()
Expand Down
4 changes: 4 additions & 0 deletions elementary/config/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,10 @@ def __init__(
run_dbt_deps_if_needed, config.get("run_dbt_deps_if_needed"), True
)

self.disable_elementary_version_check = config.get(
"disable_elementary_version_check", False
)

def _load_configuration(self) -> dict:
if not os.path.exists(self.config_dir):
os.makedirs(self.config_dir)
Expand Down
11 changes: 10 additions & 1 deletion tests/unit/config/test_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@
"token": "test_slack_token",
"channel_name": "test_channel_name",
"workflows": False,
}
},
"disable_elementary_version_check": True,
}

WORKFLOWS_CONFIG = {
Expand Down Expand Up @@ -54,6 +55,14 @@ def test_config_get_slack_notification_channel_name(config: Config):
assert config.slack_channel_name == CONFIG["slack"]["channel_name"]


@pytest.mark.parametrize("config", [CONFIG], indirect=["config"])
def test_disable_elementary_version_check(config: Config):
assert (
config.disable_elementary_version_check
== CONFIG["disable_elementary_version_check"]
)


@pytest.mark.parametrize("config", [WORKFLOWS_CONFIG], indirect=["config"])
def test_slack_workflows_config_get_workflows(config: Config):
assert config.is_slack_workflow == WORKFLOWS_CONFIG["slack"]["workflows"]