Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port to Gtk4 #90

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Port to Gtk4 #90

wants to merge 10 commits into from

Conversation

alainm23
Copy link
Contributor

@alainm23 alainm23 commented Sep 25, 2024 •
edited
Loading

Fix #80

  • Implement DnD
  • Refactor Gtk.Menu

danirabbit
danirabbit requested changes Sep 26, 2024
View reviewed changes
Copy link
Collaborator

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments but it looks like maybe this isn't actually ready for review? There's a lot of commented code

src/Application.vala Outdated Show resolved Hide resolved
data/Application.css Outdated Show resolved Hide resolved
src/Frontend/Widgets/ConnectBox.vala Outdated Show resolved Hide resolved
src/Frontend/MainWindow.vala Show resolved Hide resolved
src/Frontend/MainWindow.vala Show resolved Hide resolved
src/Frontend/MainWindow.vala Outdated Show resolved Hide resolved
src/Frontend/MainWindow.vala Outdated Show resolved Hide resolved
src/Frontend/MainWindow.vala Outdated Show resolved Hide resolved
src/Frontend/Widgets/FilePane.vala Outdated Show resolved Hide resolved
src/Frontend/Widgets/FilePane.vala Show resolved Hide resolved
@alainm23
Copy link
Contributor Author

I still have some features pending, but thanks for the comments.

@danirabbit
Copy link
Collaborator

Ah yeah it popped up in my notifications. Maybe better to set to draft until it's ready :)

@alainm23 alainm23 marked this pull request as draft September 26, 2024 10:57
@alainm23 alainm23 marked this pull request as ready for review September 30, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danirabbit danirabbit Awaiting requested review from danirabbit

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Port to Gtk4
2 participants
@alainm23 @danirabbit