Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(border): migrate css var & simplify docs #2663

Merged
merged 1 commit into from
Jul 25, 2021

Conversation

YunYouJun
Copy link
Member

  • migrate --el-border-radius-#{$type} & --el-box-shadow-#{$type} css var
  • add round of $--border-radius: 20px
  • simplify border docs with border-box.vue, shadow-box.vue
    • use code beautify doc style

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow Element's contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@element-bot
Copy link
Member

@jw-foss jw-foss merged commit 3181258 into dev Jul 25, 2021
@jw-foss jw-foss deleted the refactor/border-css-var branch July 25, 2021 08:27
@KawaiiZapic
Copy link
Contributor

KawaiiZapic commented Jul 26, 2021

This PR breaks way to change theme color by changing scss variables $--primary-color.
The documentation doesn't keep up yet, I spent some time to find out how to change primary color.

$--colors: (
  (
    'primary': (
       'base': teal,
    )
  )
);
$--font-path: '~element-plus/lib/theme-chalk/fonts';
@import "~element-plus/packages/theme-chalk/src/index.scss";

@jw-foss
Copy link
Member

jw-foss commented Jul 26, 2021

This PR breaks way to change theme color by changing scss variables $--primary-color.
The documentation doesn't keep up yet, I spent some time to find out how to change primary color.

$--colors: (
  (
    'primary': (
       'base': teal,
    )
  )
);
$--font-path: '~element-plus/lib/theme-chalk/fonts';
@import "~element-plus/packages/theme-chalk/src/index.scss";

Yes, we are expecting the full migration in the week, and we do feel sorry for breaking the functionalities. Sorry for wasting your time. We will complete the migration this week and update the documentation properly.

@YunYouJun
Copy link
Member Author

Sorry, the migration document is not ready yet because the overall migration work has not been completed.
We will provide migration guideline and examples when everything is done.
For more updates you can subscribe to this Issue.

#2242

And here to see all migration about css var.

https://github.com/element-plus/element-plus/pulls?q=label%3A%22css+migration%22


You can use --el-color-primary: xxx to custom primary color.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants