Skip to content

Add experimental support for MSC4308: Thread Subscriptions extension to Sliding Sync when MSC4306 and MSC4186 are enabled. #18695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 12 commits into
base: develop
Choose a base branch
from
Open

Add experimental support for MSC4308: Thread Subscriptions extension to Sliding Sync when MSC4306 and MSC4186 are enabled. #18695

wants to merge 12 commits into from

Conversation

reivilibre
Copy link
Contributor

Closes: #18436

Implements: matrix-org/matrix-spec-proposals#4308

Follows: #18674

This pull request is intended for commit-by-commit review.

  1. Update simplified sliding sync docstring

  2. spelling

  3. Add models for Thread Subscriptions extension to Sliding Sync

  4. Add overload for gather_optional_coroutines/6

  5. Add thread subscriptions position to StreamToken

  6. Add subscribed and automatic to get_updated_thread_subscriptions_for_user

  7. Implement MSC4308

  8. Put MSC4308 behind the MSC4306 feature flag

@reivilibre reivilibre changed the title Add experimental support for [MSC4308: Thread Subscriptions extension to Sliding Sync](https://github.com/matrix-org/matrix-spec-proposals/pull/4308) when [MSC4306: Thread Subscriptions](https://github.com/matrix-org/matrix-spec-proposals/pull/4306) and [MSC4186: Simplified Sliding Sync](https://github.com/matrix-org/matrix-spec-proposals/pull/4186) are enabled. Add experimental support for MSC4308: Thread Subscriptions extension to Sliding Sync when MSC4306 and MSC4186 are enabled. Jul 18, 2025
@reivilibre reivilibre force-pushed the rei/ssext_threadsubs branch 2 times, most recently from e40211b to 7634587 Compare July 21, 2025 16:13
@reivilibre reivilibre force-pushed the rei/ssext_threadsubs branch from 7634587 to ba41526 Compare July 21, 2025 17:32
@reivilibre reivilibre marked this pull request as ready for review July 21, 2025 20:13
@reivilibre reivilibre requested a review from a team as a code owner July 21, 2025 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-Sync A-Threads
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Threads 2.0: Design and implement a sliding sync extension for threads
2 participants
@reivilibre @MadLittleMods