Skip to content

Conversation

@MadLittleMods
Copy link
Contributor

@MadLittleMods MadLittleMods commented Jan 9, 2025

Increase rc_invites.per_issuer (invite rate limit) for Complement

It's possible to run into SynapseError: 429 - Too Many Requests (rc_invites.per_issuer)

rc_invites.per_issuer was originally introduced in matrix-org/synapse#13125

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct
    (run the linters)

It's possible to run into `SynapseError: 429 - Too Many Requests (rc_invites.per_issuer)`
burst_count: 1000
per_issuer:
per_second: 1000
burst_count: 1000
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Config documentation for reference: https://github.com/element-hq/synapse/blob/aab3672037ee9ea71c54c89c86d9c0cc35ae184f/docs/usage/configuration/config_documentation.md#rc_invites

Looks like we just forgot to define this one so it's set really low with the default.

@MadLittleMods MadLittleMods marked this pull request as ready for review January 10, 2025 00:02
@MadLittleMods MadLittleMods requested a review from a team as a code owner January 10, 2025 00:02
@MadLittleMods MadLittleMods merged commit e2d757f into develop Jan 13, 2025
37 checks passed
@MadLittleMods MadLittleMods deleted the madlittlemods/increase-rc_invites-per_issuer branch January 13, 2025 21:01
@MadLittleMods
Copy link
Contributor Author

Thanks for the review @anoadragon453 🦒

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants