Drop fewer caches when we delete old rooms #17128
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikjohnston
force-pushed
the
erikj/fewer_cache_drops
branch
from
1ba1455 to
8488a9b
Compare
erikjohnston
force-pushed
the
erikj/fewer_cache_drops
branch
from
4bf3d6f to
c7d897d
Compare
Comment on lines
+427
to
+428
| server_in_room: Whether the server was joined or invited to the | ||
| room when we deleted it. |
Member
There was a problem hiding this comment.
Do we care if the server has knocked on the room?
Member
Author
There was a problem hiding this comment.
Hmm, now I can't remember why I included invite. It's basically whether we need to invalidate stuff due to current_state_events table changing, which should be empty unless the server is joined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #17083.The aim here is to reduce the number of caches that get completely cleared when we delete rooms. Now we have a background job that deletes old rooms this happens a lot.
There's a few things going on here, sorry: