Opening room links with ?via does not work and shows no error

[matthijskooijman]

When I open a link like:

https://matrix.to/#/!gPiZOnZNGoVDyQhYpG:matrix.org?via=matrix.org

I get asked whether to use the Riot app as expected. However when I do so, a window pops up for a fraction of a second and immediately disappears again. Removing ?via=matrix.org from the url makes it work as expected.

In logcat, I get this:

--------- beginning of system
02-22 18:32:36.174  2382  4348 I ActivityManager: START u0 {act=android.intent.action.VIEW cat=[android.intent.category.BROWSABLE] dat=https://matrix.to/... flg=0x13080000 cmp=im.vector.alpha/im.vector.activity.VectorUniversalLinkActivity (has extras)} from uid 10091 on display 0
02-22 18:32:36.304  2382  2407 I art     : Background partial concurrent mark sweep GC freed 4187(404KB) AllocSpace objects, 1(20KB) LOS objects, 33% free, 18MB/27MB, paused 2.470ms total 104.791ms
02-22 18:32:36.307 30673 30673 D VectorApp: onActivityCreated im.vector.activity.VectorUniversalLinkActivity@870323
02-22 18:32:36.357 30673 30673 D VectorUniversalLinkReceiver: ## onReceive() IN
02-22 18:32:36.357 30673 30673 D VectorUniversalLinkReceiver: ## onReceive() uri getDataString=https://matrix.to/#/!gPiZOnZNGoVDyQhYpG:matrix.org?via=matrix.orgisSessionActive=true isLoginStepDone=true
02-22 18:32:36.358 30673 30673 D VectorUniversalLinkReceiver: ## onReceive() action = BROADCAST_ACTION_UNIVERSAL_LINK
02-22 18:32:36.358 30673 30673 D VectorUniversalLinkReceiver: ## onCreate() intentUri - host=matrix.to path=/ queryParams=null
02-22 18:32:36.359 30673 30673 E VectorUniversalLinkReceiver: ## parseUniversalLink : empty dictionary
02-22 18:32:36.359 30673 30673 E VectorUniversalLinkReceiver: ## onReceive() Path not supported: /
02-22 18:32:36.399 26881  5582 I OpenGLRenderer: Initialized EGL, version 1.4
02-22 18:32:36.528 30673 30673 D VectorApp: onActivityDestroyed im.vector.activity.VectorUniversalLinkActivity@870323
02-22 18:32:36.536 30673 30673 E Memory usage: Active application : onTrimMemory from VectorHomeActivity level=20
02-22 18:32:36.537 30673 30673 E Memory usage: ---------------------------------------------------
02-22 18:32:36.538 30673 30673 E Memory usage: ----------- onTrimMemory -----------------
02-22 18:32:36.539 30673 30673 E Memory usage: ---------------------------------------------------
02-22 18:32:36.539 30673 30673 E Memory usage: usedSize   35 MB
02-22 18:32:36.540 30673 30673 E Memory usage: freeSize   7 MB
02-22 18:32:36.540 30673 30673 E Memory usage: totalSize  43 MB
02-22 18:32:36.540 30673 30673 E Memory usage: ---------------------------------------------------
02-22 18:32:36.542 30673 30673 E Memory usage: availMem   509 MB
02-22 18:32:36.542 30673 30673 E Memory usage: totalMem   1876 MB
02-22 18:32:36.542 30673 30673 E Memory usage: threshold  134 MB
02-22 18:32:36.543 30673 30673 E Memory usage: lowMemory  false
02-22 18:32:36.543 30673 30673 E Memory usage: ---------------------------------------------------
02-22 18:32:37.147  2382  4521 W ActivityManager: Finishing task with all activities already finished
02-22 18:32:37.147  2382  4521 W ActivityManager: Duplicate finish request for ActivityRecord{4051b97 u0 android/com.android.internal.app.ResolverActivity t7395 f}

Note the (somewhat misleading IMHO) onReceive() Path not supported: / message in there.

It seems there are two problems here:

• Links with ?via are not supported (I'm not sure how well specified these links are, but this link is generated by Riot web, so I would be nice to support it).
• No error message is shown.

It seems all this also applies to riot.im links rather than matrix.org links (though I can't quite remember how I got a riot.im link with a ?via appended, but I did actually send it to myself during testing at some point).

[matthijskooijman]

For reference, it seems the ?via option was introduced here: matrix-org/matrix-react-sdk#2250