Skip to content
This repository has been archived by the owner on Oct 16, 2024. It is now read-only.

Fix huge usage bandwidth and performance issue of pinned message banner. #37

Merged
merged 2 commits into from
Sep 13, 2024
Merged

Fix huge usage bandwidth and performance issue of pinned message banner. #37

merged 2 commits into from
Sep 13, 2024

Conversation

florianduros
Copy link
Member

@florianduros florianduros commented Sep 12, 2024 •
edited
Loading

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

Closes element-hq/element-web#28041

  • Mobile displays only the first 100 pinned message. We mimic their behaviour to have the same experience across the clients.
  • Batch 10 by 10 the request

@florianduros florianduros force-pushed the florianduros/pinned-messages/limit-number-pinned-messages branch from 64f6390 to 52846d1 Compare September 12, 2024 14:15
@florianduros florianduros changed the title Return only the first 100 pinned messages Fix huge usage bandwidth and performance issue of pinned message banner. Sep 12, 2024
@florianduros florianduros marked this pull request as ready for review September 12, 2024 15:41
@florianduros florianduros requested a review from a team as a code owner September 12, 2024 15:41
@florianduros florianduros force-pushed the florianduros/pinned-messages/limit-number-pinned-messages branch from 1144b21 to a1b369a Compare September 12, 2024 16:31
robintown
robintown approved these changes Sep 12, 2024
View reviewed changes
test/utils/promise-test.ts Outdated Show resolved Hide resolved
@florianduros florianduros force-pushed the florianduros/pinned-messages/limit-number-pinned-messages branch from a1b369a to 8c33a0d Compare September 13, 2024 07:31
@florianduros florianduros added this pull request to the merge queue Sep 13, 2024
Merged via the queue into develop with commit 6b384fe Sep 13, 2024
27 checks passed
@florianduros florianduros deleted the florianduros/pinned-messages/limit-number-pinned-messages branch September 13, 2024 08:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@robintown robintown robintown approved these changes

@dbkr dbkr Awaiting requested review from dbkr dbkr is a code owner automatically assigned from element-hq/element-web-reviewers

Assignees
No one assigned
Labels
T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New Pin Room Banner: Unavoidable performance and bandwidth issues at high pinned message count.
2 participants
@florianduros @robintown