Unify registrations for local passwords and upstream OAuth registrations #5281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
sandhose
commented
Nov 21, 2025
sandhose
commented
- Allow completing user email authentications using an upstream session
- Store upstream OAuth sessions on user registrations
- Don't error out if there is no email associated to the registration
- Associate the upstream link with the new user if present on the registration
- Create user registrations for upstream OAuth registrations
This will let us push emails in user registrations using an upstream session
This will allow us creating user registrations from upstream OAuth auth sessions
In case an email is required for password auth, we create a user authentication which we force the user to complete. We used to double-check that the email is required before completing the registration, which was only really useful when the config flipped from not being required to being required, in the 1h window in which running registrations were still valid. We think this is a fine trade-off.
Deploying matrix-authentication-service-docs with
|
| Latest commit: |
fd8afc8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2c0a84be.matrix-authentication-service-docs.pages.dev |
| Branch Preview URL: | https://quenting-upstream-user-regis.matrix-authentication-service-docs.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.